Open
Conversation
- Fix type error in provider_handler.py: Change 'image' to 'image_url' to match MessageImageContent type - Remove trailing whitespace in huggingface_provider.py - Fix import order in worker/__main__.py - Fix import order in scripts/export_parity_snapshot.py - Remove unnecessary mode arguments in patch files The main fix addresses a type error where the wire format used 'type="image"' but the MessageImageContent class expects 'type="image_url"'. This aligns with the OpenAI API format for image content in messages. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed type error and linting issues to improve code quality:
Type Error Fix: Fixed incorrect type literal in
provider_handler.py"image"to"image_url"to matchMessageImageContenttype definitionLinting Fixes:
huggingface_provider.pyworker/__main__.pyscripts/export_parity_snapshot.pyTest plan
make typecheckpassesmake lintpasses (minor I001 warnings remain in other files)pytest tests/worker/ -v)Files changed
src/nodetool/worker/provider_handler.py- Fixed type literalsrc/nodetool/providers/huggingface_provider.py- Fixed whitespacesrc/nodetool/worker/__main__.py- Fixed import orderscripts/export_parity_snapshot.py- Fixed import orderpatch_file.py,patch_tests.py- Removed unnecessary mode args🤖 Generated with Claude Code