feat(toggle-preloading): add param to disable preloading#7638
Open
Xenossolitarius wants to merge 1 commit into
Open
feat(toggle-preloading): add param to disable preloading#7638Xenossolitarius wants to merge 1 commit into
Xenossolitarius wants to merge 1 commit into
Conversation
Xenossolitarius
force-pushed
the
toggle-lazyload-listeners
branch
from
cf7efd0 to
7fea02d
Compare
4 tasks
Adds a `lazyPreload` option (default `true`, fully backward compatible). When set to `false`, Swiper attaches no image `load` listeners and does no preloader work: - skips the capture-phase `load` listener on the root element, so onLoad -> swiper.update() no longer fires on every image load (the layout reflow that caused the performance issue); - skips per-image `load` listeners attached at init; - update() skips the [loading="lazy"] scan; - processLazyPreloader/preload early-return. Lets users who manage lazy loading themselves opt out of the reflows. Closes nolimits4web#7570
Xenossolitarius
force-pushed
the
toggle-lazyload-listeners
branch
from
7fea02d to
c358aa8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ability to toggle preloading of images. If the user doesn't want to rely on the swiper implementation the user is unable to opt out of it and infers huge performance penalties.
More in #7570