feat: Support option to access req.headers.host in dynamic routes function#218
Open
rylax wants to merge 2 commits intonuxt-community:devfrom
Open
feat: Support option to access req.headers.host in dynamic routes function#218rylax wants to merge 2 commits intonuxt-community:devfrom
rylax wants to merge 2 commits intonuxt-community:devfrom
Conversation
|
I'd like this aswell, I've used your "hacky" solution, works perfect. |
Contributor
|
Do you mind taking a look at it @NicoPennec ? |
Member
|
in your commit it is necessary to restore the 25th line |
Author
Thanks for pointing it out. Corrected it now. One can see that this is my first PR as the commit doesn't seem to go through the checks either 😬 |
|
@NicoPennec could you check this PR please? |
|
Is this going to get picked up someday? |
|
we need this feature |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows you to access req.headers.host when dynamically generating routes as requested in #217 #216 #215 #11
✨ Helpful for multi-tenant projects where the subdomain is needed to identify a user [user].maindomain.com
In order to use it the
dynamicHostoption must be enabled. Then thehostparameter is available to be used in the routes function.See example:
––––––––––––-
This is my first PR ever on Github and the solution is quite hacky – so please take it with a grain of salt and see it more as an inspiration on how this functionality could be achieved.