Fix bug where SphereTracer's max ray length was not updated.#105
Open
deivse wants to merge 1 commit intonvidia-isaac:publicfrom
Open
Fix bug where SphereTracer's max ray length was not updated.#105deivse wants to merge 1 commit intonvidia-isaac:publicfrom
deivse wants to merge 1 commit intonvidia-isaac:publicfrom
Conversation
… whenever max integration distance is changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
ProjectiveAppearanceIntegrator, theSphereTracer's max ray length was initialized once at construction to the value ofmax_integration_distance_m_. However,max_integration_distance_m_can be updated later via setter, which did not update the max ray length.Fix is by making the setter virtual and overriding in
ProjectiveAppearanceIntegratorto also set max ray length.I think this might be the issue reported in #94.