nym-node-setup: plumb HOST_SSH_PORT through tunnel manager, CLI, and env setup#6633
Open
p17o wants to merge 3 commits intonymtech:developfrom
Open
nym-node-setup: plumb HOST_SSH_PORT through tunnel manager, CLI, and env setup#6633p17o wants to merge 3 commits intonymtech:developfrom
p17o wants to merge 3 commits intonymtech:developfrom
Conversation
|
Someone is attempting to deploy a commit to the nyx-network Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@serinko next improvement will be to allow specifying the host ssh interface (e.g. for folks using tailscale). Happy to add to this one, let me know once you're done reviewing |
Contributor
|
Hey, I went through it quickly and it looks very good. Definitely want to do a proper review, testing and merge it before EOW. Really appreciate your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the host management SSH port configurable across the
nym-node-setupflow instead of hardcoding port22in the tunnel manager.It also removes host firewall drift in
network-tunnel-manager.shby using shared host firewall port definitions for configuration, status, and test output.What changed
scripts/nym-node-setup/network-tunnel-manager.shHOST_SSH_PORTwith a default of22HOST_SSH_PORTas an integer in the range1..65535ENV_FILE(or localenv.sh) so the script can consume operator-provided configuration22in host firewall handling4443was opened during configuration but not shown in status output or checked in test outputscripts/nym-node-setup/nym-node-cli.py--host-ssh-portHOST_SSH_PORTinto the generatedenv.shscripts/nym-node-setup/setup-env-vars.shHOST_SSH_PORTenv.shHOST_SSH_PORTin the confirmation summaryHOST_SSH_PORTin the generated env fileWhy
Before this change:
224443was configured but omitted from status and test outputUsing
HOST_SSH_PORTmakes it explicit that this setting controls the host's management SSH port, not any SSH-related traffic that might be relevant to exit-policy handling.Backwards compatibility
HOST_SSH_PORTis not set22Examples
Interactive setup: