Handle split IPv4/IPv6 uplinks in network-tunnel-manager#6640
Open
p17o wants to merge 1 commit intonymtech:developfrom
Open
Handle split IPv4/IPv6 uplinks in network-tunnel-manager#6640p17o wants to merge 1 commit intonymtech:developfrom
p17o wants to merge 1 commit intonymtech:developfrom
Conversation
|
Someone is attempting to deploy a commit to the nyx-network Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes
network-tunnel-manager.shfor hosts where IPv4 and IPv6 use different uplink interfaces.Before this change, the script auto-detected a single
NETWORK_DEVICEfrom the IPv4 default route and reused it for both IPv4 and IPv6 iptables/ip6tables setup. On hosts where IPv4 egress is on one interface and IPv6 egress is on another, this caused IPv6 tunnel connectivity checks and forwarding/NAT setup to fail.What changed
NETWORK_DEVICE_V4NETWORK_DEVICE_V6NETWORK_DEVICEas a backward-compatible override for both familiesWhy this is needed
Some deployments use:
In that setup, reusing the IPv4 uplink for IPv6 breaks the IPv6 path even when the host itself has working IPv6 on a different interface.
Backward compatibility
Existing setups that use a single uplink remain unchanged:
NETWORK_DEVICEstill works as beforeValidation
Tested on a host with:
eth0eth2Results:
nymwgandnymtun0succeededNotes
This change is intentionally scoped to uplink selection and rule application only.
It does not change the existing behavior for single-uplink hosts.
This change is