Open
Conversation
added 9 commits
January 28, 2019 19:13
Instead of passing around access token as a global variabler / function argument let the token live as a class variable.
|
@yurm04 Has this project gone stale? |
Contributor
Contributor
|
@Graborg thanks for your patience. I'm trying to debug some failing tests in Travis CI before reviewing this PR. Sorry again for the delay 🙇♀ |
Contributor
|
@Graborg just starting to review and test this PR. When I try to run I'm currently using: I tested master to make sure app runs there with current versions and seems to work. Could you post your system info and run this branch locally? |
Contributor
Author
|
Sure, I'll take a look. might have omitted something. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
motivation
This PR removes some minor inconsistencies/bugs but mainly it adds the option of authenticating as github app instead of a single user.
This makes it easier to manage use for organizations, without creating a dedicated user.
What kind of change does this PR introduce?
It add the option of running the service as a Github app. If the argument AUTH_AS_APP is omitted. The service will function as normal.
Did you add tests for your changes?
Yes.
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
Nothing, already added.