Skip to content

fix: simplify power_pin configuration#6

Merged
oarcher merged 6 commits into
oarcher:gsmfrom
Rapsssito:multiple-interfaces
Feb 10, 2026
Merged

fix: simplify power_pin configuration#6
oarcher merged 6 commits into
oarcher:gsmfrom
Rapsssito:multiple-interfaces

Conversation

@Rapsssito

@Rapsssito Rapsssito commented Feb 9, 2026

Copy link
Copy Markdown

Working on oarcher/esphome-docs#2, I realized that the configuration for the power_pin from #5 was redundant and could be simplified.

@Rapsssito Rapsssito requested a review from oarcher as a code owner February 9, 2026 13:24
@Rapsssito Rapsssito marked this pull request as draft February 9, 2026 14:37
@Rapsssito Rapsssito marked this pull request as ready for review February 9, 2026 15:15
@oarcher

oarcher commented Feb 9, 2026

Copy link
Copy Markdown
Owner

Many thanks for your contribution, @Rapsssito — much appreciated!

However, could you please split this PR?

For this PR, I’d like to keep only the changes under components/modem.
The modem component is already quite large, and it will be much harder for core developers to review and merge it if it also modifies multiple unrelated components.

More specifically:

  • The change around checking whether esp_event_loop_create_default() was already called (handling ESP_ERR_INVALID_STATE) affects several core components. This should probably be proposed as a separate PR against the main ESPHome dev branch, and discussed directly with the core developers. If accepted, we can then rely on it from the modem component.
  • Same idea for the change in components/network/util.cpp, but it can probably be skipped, as it’s just a semantic rewrite.

@Rapsssito

Copy link
Copy Markdown
Author

@oarcher, yeah I also worried about that. I have removed those parts from this PR and created a new one in the main repo (esphome#13896).

@Rapsssito Rapsssito changed the title fix: allow multiple interfaces fix: add potential support for multiple interfaces Feb 9, 2026
@Rapsssito Rapsssito changed the title fix: add potential support for multiple interfaces fix: simplify power_pin configuration Feb 9, 2026
@Rapsssito

Copy link
Copy Markdown
Author

@oarcher, I have removed everything related to multiple interfaces to just simplify the power pin config and match the new docs (oarcher/esphome-docs#2).

@oarcher oarcher left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help!

@oarcher oarcher merged commit 965ede3 into oarcher:gsm Feb 10, 2026
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants