checks: Implement bespoke version parser#191
Merged
RytoEX merged 2 commits intoobsproject:masterfrom Jan 6, 2026
Merged
Conversation
Member
this should probably just be a separate PR as it's unrelated, but, at the least should be its own commit. |
Contributor
Author
|
Do you mean the cleanup, or the new check? |
Member
|
looks good to me, did some testing on my own as well with a collection of logs and saw no issues. |
RytoEX
requested changes
Nov 5, 2025
7599526 to
eecfafb
Compare
Fenrirthviti
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This replaces the usage of
pkg_resources.parse_versionwith a version parser custom-made for OBS versioning.It obeys to the semver 2.0.0 spec except for a stricter definition of pre-release versioning.
I also took the opportunity to cleanup messages relating to long-outdated versions of obs, and to add an "oudated beta" check that was suggested in comments.
The original includes a check for "caffeine" builds of OBS as an unofficial one. Having never seen one of those in years of support I would assume it isn't relevant anymore, but without clear knowledge on what those are, I preferred to leave it in. Clarifications on their current relevance is welcome.
Motivation and Context
pkg_resources.parse_versionwas only ever meant to be used for python packages and with setuptools >= 66.0 raises an error when called on a version that doesn't conform to python packages versioning rules. As an example, the simple inclusion of a-modified, quite frequent in obs versioning, is enough to break said rules, and as such, the analyzer.While not currently breaking, as the analyzer is run on rather old python, the potential of breaking upon update is rather unwishable, and we should rely on a tool intended for the job, instead of using one in an unintended and unsupported way.
How Has This Been Tested?
Ran it with a bunch of logs plucked from the support server, observed no breaking, and proper reporting of version.
Types of changes
Checklist: