linux: Fix checkLinuxSystemInfo detection#193
Closed
prgmitchell wants to merge 1 commit intoobsproject:masterfrom
Closed
linux: Fix checkLinuxSystemInfo detection#193prgmitchell wants to merge 1 commit intoobsproject:masterfrom
prgmitchell wants to merge 1 commit intoobsproject:masterfrom
Conversation
Add an early return when 'Distribution' and 'Flatpak Runtime' are not found.
Member
|
cc @mihawk90 |
Contributor
|
I'm not sure about this fix. I think we'd have to do this a little different since what this patch does is essentially what However, this also means that both being false is essentially what this block is supposed to cover: Lines 187 to 190 in 79f7adf Which consequently would never be reached. I think we'll have to check for Windows/Mac instead and return early. I'll try whipping something up and opening an alternate PR and then we can decide. edit: |
This was referenced Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add an early return when 'Distribution' and 'Flatpak Runtime' are not found.
Motivation and Context
The distribution check was triggering for Windows and macOS logs
How Has This Been Tested?
Windows log: https://obsproject.com/logs/fol11bBs0Ia9ZfcZ

Linux log: https://obsproject.com/logs/3G0ITqDVvenAhDbA

Types of changes
Checklist: