Add neocaml-mode support to ocamlformat-before-save#2787
Add neocaml-mode support to ocamlformat-before-save#2787bbatsov wants to merge 2 commits intoocaml-ppx:mainfrom
Conversation
neocaml (https://github.com/bbatsov/neocaml) is a new tree-sitter based OCaml major mode for Emacs. Add `neocaml-mode` and `neocaml-interface-mode` to the mode whitelist in `ocamlformat-before-save` so format-on-save works in neocaml buffers.
|
Looks good to me, too bad it happened right after release |
|
Yeah, that's unfortunate. Still, I guess many people install the package from MELPA, so for them that won't be an issue. |
Julow
left a comment
Julow
left a comment
There was a problem hiding this comment.
Thanks !
Do you think we should keep a changelog for the emacs mode ? Even if it ends up being distributed in a different way, I think it would be a nice touch to have it in the main changelog.
Having a changelog is never a bad idea IMO. Should add a separate file for the package or update the main changelog? I guess that's up to you. |
|
In the main changelog in a |
|
@EmileTrotignon Done! |
3 participants
neocaml is a new tree-sitter based OCaml major mode for Emacs. This adds
neocaml-modeandneocaml-interface-modeto the mode whitelist inocamlformat-before-saveso format-on-save works in neocaml buffers.Currently users who switch from tuareg-mode to neocaml-mode lose format-on-save silently because the
memqcheck doesn't recognize the new modes.