Wake up desktops on auto deploy #119
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add ocf.managed-deployment.mac-address for setting mac addresses for hosts that should be woken up on deploy - set ocf.managed-deployment.mac-address for each desktop - add WoL on deploy to auto-deploy.yml GitHub workflow - fix typo in manual-deploy.yml: the tag is "desktop" not "desktops"
Member
Author
Member
Author
|
btw this currently has a race condition since it doesn’t wait for the desktops to finish booting before starting colmena apply. need to fix that |
scheduling the deploy as a cronjob primarily works as a bandaid fix to desktops being turned off, given that other deployment failures should be investigated directly due to this PR aiming to fix the issue of desktops being turned off, i believe this is no longer required there michael i put my thoughts in the commit are u happy
Member
|
We should still have nightly deploys because there is no downside in doing that and it is still a valid safeguard against deployment failures for any other reason. |
Member
this might genuinely be a problem, should probably have it actually check that the desktops are up before applying ..... or just a really long sleep |
Member
Author
|
it will either fail for that host like it already does, or succeed because
it was woken up. i wonder if it is even possible for it to get to the point
of running the switch to configuration script when the system is still
booting; although im not sure if that would actually break anything. i can
check it reached multi-user.target before applying i suppose? anyway, the
simplest solution is to ping the host until it is up with a timeout before
deploying, and im ok with that since deploys are parallelized
…On Tue, Feb 3, 2026 at 4:58 PM sophie ***@***.***> wrote:
*sophiebsw* left a comment (ocf/nix#119)
<#119 (comment)>
btw this currently has a race condition since it doesn’t wait for the
desktops to finish booting before starting colmena apply. need to fix that
this might genuinely be a problem, should probably have it actually check
that the desktops are up before applying
..... or just a really long sleep
—
Reply to this email directly, view it on GitHub
<#119 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/B3NNG2DNCX4LWE7NGUFXIW34KE73TAVCNFSM6AAAAACTZ6G7PWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQNBUGYZTQOJQGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hosts that should be woken up on deploy
depends on #116, needs to be tested