Skip to content

Add user-agent to events#1033

Open
wlynch wants to merge 1 commit intoocto-sts:mainfrom
wlynch:user-agent
Open

Add user-agent to events#1033
wlynch wants to merge 1 commit intoocto-sts:mainfrom
wlynch:user-agent

Conversation

@wlynch
Copy link
Copy Markdown
Collaborator

@wlynch wlynch commented Sep 2, 2025

Adds user agent to events so that they can be used to identify client trends.

@wlynch wlynch requested review from cpanato and mattmoor September 2, 2025 13:39
@wlynch wlynch changed the title Add user-agent to recorded events Add user-agent to events Sep 2, 2025
@cpanato
Copy link
Copy Markdown
Collaborator

cpanato commented Sep 2, 2025

@wlynch can you rebase and fix the conflict?

thanks!

@wlynch
Copy link
Copy Markdown
Collaborator Author

wlynch commented Sep 2, 2025

Done

return &in
}

func extractUserAgent(ctx context.Context) string {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have tests? :D

Copy link
Copy Markdown
Collaborator

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants