Skip to content

Fix privileged helper lifetime and release 17.0.3 - #80

Merged
offyotto merged 1 commit into
mainfrom
fix/smc-helper-service-lifetime
Sep 6, 2026
Merged

Fix privileged helper lifetime and release 17.0.3#80
offyotto merged 1 commit into
mainfrom
fix/smc-helper-service-lifetime

Conversation

@offyotto

@offyotto offyotto commented Sep 6, 2026

Copy link
Copy Markdown
Owner

No description provided.

@gitar-bot

gitar-bot Bot commented Sep 6, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Retains the SMCHelperXPCService throughout its run loop via withExtendedLifetime to prevent premature deallocation, with added test coverage and CI integration to verify service delegate persistence. No issues found.

Auto-approved and auto-merge armed: No blocking issues found.
Please see Auto-approve Docs for details on setting custom approval criteria. — merges when pipeline and required approvals pass.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

@gitar-bot

gitar-bot Bot commented Sep 6, 2026

Copy link
Copy Markdown

⚠️ Gitar auto-approved this PR but could not enable auto-merge: an unexpected error occurred ([{"type":"UNPROCESSABLE","path":["enablePullRequestAutoMerge"],"locations":[{"line":3,"column":9}],"message":"Pull request Pull request is in unstable status"}]).

@gitar-bot gitar-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitar has auto-approved this PR (configure)

@gitar-bot gitar-bot Bot added the gitar-approved Added by Gitar label Sep 6, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 11b0fe3548

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/release.yml
@offyotto
offyotto merged commit caed62c into main Sep 6, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gitar-approved Added by Gitar

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant