Skip to content

Update medication dispense category#3572

Merged
vigneshhari merged 1 commit intoohcnetwork:developfrom
rithviknishad:dispense-category-discharge
Mar 13, 2026
Merged

Update medication dispense category#3572
vigneshhari merged 1 commit intoohcnetwork:developfrom
rithviknishad:dispense-category-discharge

Conversation

@rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Mar 13, 2026

Proposed Changes

  • Adds discharge to medication dispense category as per FHIR

https://build.fhir.org/valueset-medicationdispense-category.html

Summary by CodeRabbit

  • New Features
    • Added "Discharge" as a new medication dispensing category option, expanding available categorization choices for medication dispensing records.

@rithviknishad rithviknishad requested a review from a team as a code owner March 13, 2026 06:34
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: c7dcbe8a-7fef-45be-b16a-35b1352da70b

📥 Commits

Reviewing files that changed from the base of the PR and between 9c0f791 and 6755975.

📒 Files selected for processing (1)
  • care/emr/resources/medication/dispense/spec.py

📝 Walkthrough

Walkthrough

Added a new "discharge" enum member to the MedicationDispenseCategory class, expanding the set of valid medication dispense categories. No additional logic modifications are present in this change.

Changes

Cohort / File(s) Summary
Medication Dispense Enum Extension
care/emr/resources/medication/dispense/spec.py
Added discharge = "discharge" enum member to MedicationDispenseCategory, bringing the total supported categories to four.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description covers proposed changes and references FHIR documentation, but omits required sections like Associated Issue, Architecture changes, and the Merge Checklist. Add the missing Merge Checklist section and confirm whether tests were added; optionally include an Associated Issue link if applicable.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding a new category to the medication dispense enum.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can generate a title for your PR based on the changes.

Add @coderabbitai placeholder anywhere in the title of your PR and CodeRabbit will replace it with a title based on the changes in the PR. You can change the placeholder by changing the reviews.auto_title_placeholder setting.

@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.22%. Comparing base (9c0f791) to head (6755975).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3572   +/-   ##
========================================
  Coverage    76.22%   76.22%           
========================================
  Files          474      474           
  Lines        22271    22272    +1     
  Branches      2325     2325           
========================================
+ Hits         16976    16977    +1     
  Misses        4766     4766           
  Partials       529      529           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vigneshhari vigneshhari merged commit 5f8f3a2 into ohcnetwork:develop Mar 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants