Fix transformations examples - #175
Merged
Merged
Conversation
* sequenceSubspace1: is invalid as a sequence; subspace transforms are byDimension * byDimensionXarray: transformation must be nested object now * mapAxis1 had deprecated string-only references
Automated Review URLs |
jo-mueller
approved these changes
Jul 30, 2026
lubianat
approved these changes
Aug 3, 2026
lubianat
left a comment
lubianat
left a comment
Contributor
There was a problem hiding this comment.
I don't really know the details. But seems self-contained and I am trusting @jo-mueller. (adding the ok so he can merge)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found after putting https://forum.image.sc/t/ngff-weekly-dev-update-thread/110810/129?u=btbest to the test and actually running all the examples through a roundtrip test :)
Edit: Just realised fixing that sequenceSubspace example makes it almost identical to the xarrayLike example, but oh well... it has a different child type 🤷