Remove strict jsonchemas and conformance test cases (v2) - #176
Open
clbarnes wants to merge 6 commits into
Open
Conversation
Automated Review URLs |
jo-mueller
reviewed
Aug 7, 2026
jo-mueller
left a comment
jo-mueller
left a comment
Contributor
There was a problem hiding this comment.
I think it looks good. I'll briefly check the build on my end
Comment on lines
-133
to
+129
| if __name__ == '__main__': | ||
| pytest.main([__file__]) No newline at end of file | ||
| if __name__ == "__main__": | ||
| pytest.main([__file__]) |
Contributor
There was a problem hiding this comment.
Feel free to remove this alltogether, I think I left this behind at some point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supercedes #140 ; resolves #138 .
Incorporates @will-moore 's feedback, migrating all of the strict examples to non-strict and updating references to them.