fix: spawn reboot in background with configurable delay#184
Merged
JanZachmann merged 1 commit intoomnect:mainfrom Nov 20, 2025
Merged
fix: spawn reboot in background with configurable delay#184JanZachmann merged 1 commit intoomnect:mainfrom
JanZachmann merged 1 commit intoomnect:mainfrom
Conversation
JanZachmann
force-pushed
the
fix-reboot-delay
branch
3 times, most recently
from
f8a8311 to
0eb7a4f
Compare
The current reboot implementation causes the service to stop immediately when reboot.target starts, preventing the D-Bus call from completing. This causes functions that call reboot to hang and fail to respond to callers. Solution: Spawn the reboot operation in a background task with a configurable delay, allowing the reboot function to return immediately and the service to respond to the caller before the system shuts down. Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
JanZachmann
force-pushed
the
fix-reboot-delay
branch
from
0eb7a4f to
1868608
Compare
empwilli
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current reboot implementation causes the service to stop immediately when
reboot.targetstarts, preventing the D-Bus call from completing. This causes functions that call reboot to hang and fail to respond to callers.Solution
Spawn the reboot operation in a background task with a configurable delay. This allows: