Skip to content

fix: ensure generated flag manifest ends with a final newline#246

Merged
beeme1mr merged 5 commits into
mainfrom
copilot/add-final-newline-to-manifest
May 20, 2026
Merged

fix: ensure generated flag manifest ends with a final newline#246
beeme1mr merged 5 commits into
mainfrom
copilot/add-final-newline-to-manifest

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 29, 2026 •
edited by beeme1mr
Loading

  • Append '\n' to formattedManifest in writeManifest (manage.go)
  • Add TestWriteManifestEndsWithNewline test in manage_test.go
  • Update success_init.golden to end with a newline (fix CI test failure)

resolves: #194

Copilot AI linked an issue Apr 29, 2026 that may be closed by this pull request
Generated flag manifest file should end with final newline #194
Closed
Copilot AI and others added 2 commits April 29, 2026 14:08
Copilot AI changed the title [WIP] Fix generated flag manifest file to end with newline fix: ensure generated flag manifest ends with a final newline Apr 29, 2026
Copilot AI requested a review from beeme1mr April 29, 2026 14:10
@beeme1mr beeme1mr marked this pull request as ready for review April 29, 2026 14:18
@beeme1mr beeme1mr marked this pull request as draft April 29, 2026 14:19
@beeme1mr
Copy link
Copy Markdown
Member

beeme1mr commented Apr 29, 2026

@copilot please address the failed unit tests.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 29, 2026

@copilot please address the failed unit tests.

Fixed in d452668. The TestInitCmd test was comparing against testdata/success_init.golden, which didn't end with a newline. Updated the golden file to match the new behavior.

@beeme1mr beeme1mr marked this pull request as ready for review April 29, 2026 19:20
@beeme1mr beeme1mr merged commit c2688a7 into main May 20, 2026
7 checks passed
@openfeaturebot openfeaturebot mentioned this pull request May 15, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kriscoleman kriscoleman Awaiting requested review from kriscoleman

2 more reviewers

@beeme1mr beeme1mr beeme1mr approved these changes

@sahidvelji sahidvelji sahidvelji approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@beeme1mr beeme1mr

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Generated flag manifest file should end with final newline

3 participants

@beeme1mr @sahidvelji