fix: give OMJob operator its own selector labels#488
Open
srlightbody wants to merge 1 commit intoopen-metadata:mainfrom
Open
fix: give OMJob operator its own selector labels#488srlightbody wants to merge 1 commit intoopen-metadata:mainfrom
srlightbody wants to merge 1 commit intoopen-metadata:mainfrom
Conversation
The operator deployment was using OpenMetadata.selectorLabels (name + instance) which are the same labels used by the server deployment and service. This caused the server's service to match operator pods in addition to server pods. The operator is a separate application and should have its own name label. Changed from inheriting the shared selectorLabels to using its own name (openmetadata-omjob-operator) while keeping the same release instance label and component label. Fixes open-metadata#482
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #482
The operator deployment uses OpenMetadata.selectorLabels which gives it the same app.kubernetes.io/name and app.kubernetes.io/instance labels as the server. Since the server Service also selects on those labels, it matches both server and operator pods.
The operator is a separate application - it should have its own name label. This PR changes the operator pod template and selector to use app.kubernetes.io/name: openmetadata-omjob-operator instead of inheriting the shared openmetadata name. It keeps the same release instance label and component label for Helm ownership tracking.
Only the operator deployment template is modified. The server deployment, service, and helpers are untouched.