Skip to content

FINERACT-2081: add api verification workflow#191

Closed
budaidev wants to merge 1 commit intodevelopfrom
FINERACT-2081/breaking-api-change-test
Closed

FINERACT-2081: add api verification workflow#191
budaidev wants to merge 1 commit intodevelopfrom
FINERACT-2081/breaking-api-change-test

Conversation

@budaidev
Copy link
Collaborator

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@github-actions
Copy link

Breaking API Changes Detected

Rule Description Detail Affected endpoints Count
R009 Request attribute removed extendTermForRepaymentsOnHolidays PUT /v1/workingdays 1
R010 Request type changed repaymentRescheduleType PUT /v1/workingdays 1
R012 Response code deleted code=default GET /v1/workingdays/template, PUT /v1/workingdays 2

Total: 4 violations across 3 unique changes

Note: This check is informational only and does not block the PR.

@budaidev budaidev force-pushed the FINERACT-2081/breaking-api-change-test branch 5 times, most recently from 81245e5 to 4887c15 Compare February 23, 2026 12:24
@budaidev budaidev force-pushed the FINERACT-2081/breaking-api-change-test branch from 4887c15 to 1b6c378 Compare February 23, 2026 13:42
@budaidev budaidev closed this Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant