fix(sync): land kmp-project-template sync + fix all resulting build regressions - #2064
Draft
therajanmaurya wants to merge 7 commits into
Draft
fix(sync): land kmp-project-template sync + fix all resulting build regressions#2064therajanmaurya wants to merge 7 commits into
therajanmaurya wants to merge 7 commits into
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
therajanmaurya
force-pushed
the
session-mobile-wallet-20260819181213704
branch
from
August 19, 2026 14:23
9b1840c to
7787b2f
Compare
…spath.tree.txt cmp-android/dependencies/prodReleaseRuntimeClasspath.txt cmp-navigation/build.gradle.kts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Syncs mifos-pay with the latest
openMF/kmp-project-template(offline-first Store5/Roommigration, sync-engine fixes from upstream PR #292/#293) and repairs every compile, test, and
DI-wiring regression the sync introduced so all PR checks pass locally byte-identical to CI
(
/idea-ci-pr— 7/7 exact checks green, 0 failed, 0 approx-warnings).Changes
dev(worker-kmp sync infra, core-baseBookkeeper/Draft/FetchedAt relocation, product-health checks, white-label scripts) through the
fixed
sync-dirs.shengine.core.common/core.model/core.datastore/core.network/core.domain/core.designsystemwhere the sync had added source files withoutwiring their module deps, across
feature/{autopay,passcode,mpay-qr,history,send-money,home, settings,profile,transfer-intrabank},cmp-navigation, andcmp-shared(the latter wasmissing all ~30 feature-module deps +
core.common/core.domain/core.network).core.model/core.datastore/core.networkfromimplementationtoapiincore/data(mirroring the existingapi(core.store)pattern) soevery feature module gets them transitively instead of repeating the declaration, and features
no longer reach
core/networkdirectly.jetbrainsCompose/compose.compilerplugins +
compose.runtime/compose.components.resourcestocore/common,core/network,core/data,core/designsystem,core/ui,feature/home,feature/mpay-qr— the sync hadadded compose-resource-consuming files without wiring the compose plugin that generates
Res.org.mifospay.core.network.model→org.mifospay.core.model.network: relocates the fullnetwork DTO/entity package (59 files) into
core/modelso it's reachable through the existingcore.modelre-export instead of a directcore/networkdependency.blind-overwrote them with the template's demo/skeleton versions):
AppDatabase.kt'sFetchedAtDao/FetchedAtEntityimports +core/database/schemas/{1,6,7,8}.json(realmigration history, not the template's demo schema);
cmp-navigation/AppViewModel.kt+ComposeApp.kt(401 forced-logout, background re-auth lock, instance-selector overlay —~330 lines of real security logic);
cmp-shared/utils/KoinExt.kt(the fork's ~30 feature-moduleKoin registration, silently dropped so no feature ViewModel would have resolved at runtime);
core/databasedesktop unit tests (AppDatabaseTest/DatabaseModuleTest/FetchedAtDaoTest)that had been overwritten with the template's own demo-DAO tests.
per-platform
core/platform/.../notification/bill/**WorkManager scheduler (replaced bysync/WorkScheduler+worker-kmp);BaseDraftMutationViewModel/BaseSubmitMutationViewModel(superseded by the unified
BaseMutationViewModel); demo-onlyOutboxQualifiers+RepositoryModuleVerifyTest;DataSyncWorker's demo currency/economic-indicator syncers; 3cmp-navigation/authenticatednavbarfiles already documented as deleted but never removed;orphaned demo-dependent UI tests in
feature/homeandfeature/settings(rewritten against thereal template shell instead of the fork's nonexistent demo body).
strings.xmlkeys (feature/home,feature/settings— theme/dark-mode/sync-and-drafts/notifications-empty strings) that existedonly in translated locales after the sync's strings merge.
gradle.propertiesheap to-Xmx8g; regenerates the driftedkotlin-js-store/yarn.lock.Notable files
core/data/build.gradle.kts—apire-exports forcore.model/core.datastore/core.networkcmp-shared/build.gradle.kts,cmp-shared/src/commonMain/kotlin/cmp/shared/utils/KoinExt.ktcmp-navigation/src/commonMain/kotlin/cmp/navigation/{AppViewModel,ComposeApp}.ktcore/database/src/commonMain/kotlin/kpt/core/database/AppDatabase.ktUpstream
Proposes
openMF/kmp-project-template#296(schemas/** exclusion + template-deletionpropagation) to prevent this class of sync clobber from recurring on future syncs, in any fork.