A reimport task got suddenly quite useful over the weekend#31
Open
coolo wants to merge 1 commit into
Open
Conversation
Unfortunately it requires more work - as often the infos in bot_sources are outdated. So for a useful reimport we need to dig for the verifymd5 in all known products. for the weekend incident I did just that as I only needed to restore those actually in products. My aim was actually reimporting past reviews, but that is much harder
kraih
reviewed
Jul 31, 2019
| {name => $pkg->{name}, id => {'!=', $pkg->{id}}, state => 'new'}) | ||
| ->hashes | ||
| } | ||
| ) |
Member
There was a problem hiding this comment.
my $results = $db->select(
'bot_packages',
['id', 'priority'],
{name => $pkg->{name}, id => {'!=', $pkg->{id}}, state => 'new'}
)->hashes;
for my $opkg (@$results) {
Member
|
Very useful indeed, wish it had tests though. |
Member
Author
I don't plan to merge it before my vacation - I needed it for panic recovery, but now we're fine :) |
Member
Author
|
if it wasn't useful for the last 5 years, I guess we can rest the case |
Member
|
It's not that it isn't useful, just the lack of tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately it requires more work - as often the infos in bot_sources
are outdated. So for a useful reimport we need to dig for the verifymd5
in all known products. for the weekend incident I did just that as I only
needed to restore those actually in products.
My aim was actually reimporting past reviews, but that is much harder