chore!: remove legacy database upgrade path#767
Conversation
RussH
left a comment
There was a problem hiding this comment.
Thanks, good cleanup.
One point to clarify before merge: the PR description says the optional ZIP code upgrade file is intentionally kept because it is still used by the optional ZIP code component. My understanding is that the older ziplookup code has effectively been superseded by lib/ZipLookup.php, and this PR also removes the upgradeCats path which previously ran upgrade-zipcodes.sql. Could you please confirm whether that ZIP upgrade file is still genuinely used by current code? If not, I’d prefer either removing it in this PR or noting it as a follow-up cleanup.
Assuming that ZIP lookup point is clarified, this looks good to me.
|
I checked this again and The removed The runtime ZIP distance filtering is still tied to the local I agree that the filename is a bit misleading now that the legacy upgrade path is gone. Renaming or moving it could make sense as a separate follow-up cleanup, but I think it should stay in this PR. |
This PR removes the obsolete legacy database upgrade path that depended on standalone
db/upgrade-*.sqlfiles.The removed installer path previously detected historical OpenCATS database revisions and applied old version-to-version SQL upgrade scripts.
Fresh installations continue to use
db/cats_schema.sql. Existing compatible OpenCATS installations continue through the current installer flow and schema maintenance path.The optional ZIP code upgrade file is intentionally kept because it is still used by the optional ZIP code component.