fix(mlx): tolerate invalid UTF-8 VLM tokens - #5382
Open
accelizero wants to merge 1 commit into
Open
accelizero wants to merge 1 commit into
accelizero wants to merge 1 commit into
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Older
mlx-vlmreleases strictly decode the pending byte-level BPE buffer. A generated byte-fallback token followed by a space-prefixed token can raiseUnicodeDecodeErrorand abort the full MinerU VLM task.Modification
mlx-vlmreleases at MLX engine initialization.errors="replace"unchanged.Validation
2 passed.mlx-vlm 0.3.9,mlx 0.31.1, andtransformers 4.57.6.BC-breaking
No. The patch only prevents an MLX VLM generation crash; non-MLX backends and already-fixed
mlx-vlmversions are unchanged.This branch is based on the locally tested Git commit. The earlier web-editor PRs were closed because their new files had incorrect nested paths.