fix(xlsx): preserve images anchored in merged cells - #5388
Open
xiejinwen113 wants to merge 1 commit into
Open
xiejinwen113 wants to merge 1 commit into
xiejinwen113 wants to merge 1 commit into
Conversation
dosubot
Bot
added
size:S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Images anchored to non-top-left cells inside an XLSX merged range were emitted under hidden merged-cell coordinates. As a result, only one image remained visible in the generated table output when several images belonged to the same merged cell.
Modification
BC-breaking
No.
Checklist
Before PR:
git diff --checkpasses.Test:
uv run --with pytest pytest -o addopts='' -q tests/unittest/test_xlsx_converter.py(1 passed).