Open
Conversation
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
lsiepel
added
bug
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to resolve a channel-type ID collision in the Intesis binding that caused the errorStatus channel to end up with the wrong item type (see issue #19533), by splitting the conflicting channel types and adding an update instruction to migrate existing Things.
Changes:
- Add an update description (
thingTypeVersion+instruction.xml) to migrateerrorStatuschannel types. - Rename the colliding channel-type IDs into distinct
errorStatusStringanderrorStatusSwitch. - Update Java handlers/constants and README to reflect the intended types per Thing.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| bundles/org.openhab.binding.intesis/src/main/resources/OH-INF/update/instruction.xml | Adds migration instructions to change the errorStatus channel’s type. |
| bundles/org.openhab.binding.intesis/src/main/resources/OH-INF/thing/thing-types.xml | Adds thingTypeVersion; renames the String errorStatus channel-type. |
| bundles/org.openhab.binding.intesis/src/main/resources/OH-INF/thing/dynamic-channels.xml | Renames the Switch errorStatus channel-type. |
| bundles/org.openhab.binding.intesis/src/main/java/org/openhab/binding/intesis/internal/handler/IntesisHomeHandler.java | Updates dynamic channel creation/state updates for errorStatus. |
| bundles/org.openhab.binding.intesis/src/main/java/org/openhab/binding/intesis/internal/handler/IntesisBoxHandler.java | Updates state updates for errorStatus. |
| bundles/org.openhab.binding.intesis/src/main/java/org/openhab/binding/intesis/internal/IntesisBindingConstants.java | Splits errorStatus constants into String/Switch variants. |
| bundles/org.openhab.binding.intesis/README.md | Documents differing errorStatus item types per Thing type. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...g.intesis/src/main/java/org/openhab/binding/intesis/internal/handler/IntesisHomeHandler.java
Outdated
Show resolved
Hide resolved
...g.intesis/src/main/java/org/openhab/binding/intesis/internal/handler/IntesisHomeHandler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.intesis/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.intesis/src/main/resources/OH-INF/thing/dynamic-channels.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.intesis/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
...ding.intesis/src/main/java/org/openhab/binding/intesis/internal/IntesisBindingConstants.java
Show resolved
Hide resolved
...ng.intesis/src/main/java/org/openhab/binding/intesis/internal/handler/IntesisBoxHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
hmerk
approved these changes
Mar 29, 2026
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...ding.intesis/src/main/java/org/openhab/binding/intesis/internal/IntesisBindingConstants.java
Outdated
Show resolved
Hide resolved
...g.intesis/src/main/java/org/openhab/binding/intesis/internal/handler/IntesisHomeHandler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.intesis/src/main/resources/OH-INF/i18n/intesis.properties
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.intesis/src/main/resources/OH-INF/i18n/intesis.properties
Outdated
Show resolved
Hide resolved
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
errorStatushas wrong itemtype #19533