Open
Conversation
10b6892 to
e1a5084
Compare
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com> initial version Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com> cleanup Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
ebf6692 to
31663d9
Compare
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com> correct readme link Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
8e9b254 to
0a4f257
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Dirigera Matter support for IKEA smart plugs (e.g., GRILLPLATS / TOFSMYGGA) by introducing a new Matter outlet thing type, mapping outlet + electrical-sensor relations, and extending the Matter model to support additional state/command conversions.
Changes:
- Add a new
matter-outletthing type and discovery/identification mapping for Matteroutlet+electricalSensordevices. - Extend Matter device configuration (
devices.json) to expose power/startup and electrical measurement channels for these devices. - Add tests and test fixtures for GRILLPLATS and update existing test expectations accordingly.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| bundles/org.openhab.binding.dirigera/src/main/java/org/openhab/binding/dirigera/internal/model/MatterModel.java | Adds DateTime state conversion, format transformation for commands, numeric command parsing, and extra logging for unknown device types. |
| bundles/org.openhab.binding.dirigera/src/main/java/org/openhab/binding/dirigera/internal/model/DirigeraModel.java | Identifies Matter outlet/electricalSensor devices as THING_TYPE_MATTER_OUTLET. |
| bundles/org.openhab.binding.dirigera/src/main/java/org/openhab/binding/dirigera/internal/handler/matter/MatterOutlet.java | New handler class for Matter outlet things (currently a thin BaseMatterHandler wrapper). |
| bundles/org.openhab.binding.dirigera/src/main/java/org/openhab/binding/dirigera/internal/DirigeraHandlerFactory.java | Wires the new THING_TYPE_MATTER_OUTLET to the new MatterOutlet handler. |
| bundles/org.openhab.binding.dirigera/src/main/java/org/openhab/binding/dirigera/internal/Constants.java | Adds THING_TYPE_MATTER_OUTLET and includes it in supported types. |
| bundles/org.openhab.binding.dirigera/src/main/resources/json/matter/devices.json | Adds device model entries for outlet and electricalSensor including channel mappings. |
| bundles/org.openhab.binding.dirigera/src/main/resources/OH-INF/thing/matter.xml | Declares the new matter-outlet thing-type. |
| bundles/org.openhab.binding.dirigera/src/main/resources/OH-INF/i18n/dirigera.properties | Adds i18n label/description keys for matter-outlet. |
| bundles/org.openhab.binding.dirigera/README.md | Documents the new Matter plug thing type. |
| bundles/org.openhab.binding.dirigera/src/test/java/org/openhab/binding/dirigera/internal/model/TestModel.java | Updates expected device/discovery counts for the new fixtures. |
| bundles/org.openhab.binding.dirigera/src/test/java/org/openhab/binding/dirigera/internal/handler/matter/TestMatterOutlet.java | Adds handler creation/initialization/command tests for Matter outlets. |
| bundles/org.openhab.binding.dirigera/src/test/resources/home/matter-home.json | Adds GRILLPLATS outlet + electrical sensor devices to the simulated home model. |
| bundles/org.openhab.binding.dirigera/src/test/resources/devices/grillplats.json | Adds a dedicated GRILLPLATS device fixture. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
....binding.dirigera/src/main/java/org/openhab/binding/dirigera/internal/model/MatterModel.java
Show resolved
Hide resolved
....binding.dirigera/src/main/java/org/openhab/binding/dirigera/internal/model/MatterModel.java
Show resolved
Hide resolved
....binding.dirigera/src/main/java/org/openhab/binding/dirigera/internal/model/MatterModel.java
Show resolved
Hide resolved
....binding.dirigera/src/main/java/org/openhab/binding/dirigera/internal/model/MatterModel.java
Show resolved
Hide resolved
...irigera/src/main/java/org/openhab/binding/dirigera/internal/handler/matter/MatterOutlet.java
Show resolved
Hide resolved
bundles/org.openhab.binding.dirigera/src/main/resources/json/matter/devices.json
Show resolved
Hide resolved
bundles/org.openhab.binding.dirigera/src/test/resources/devices/grillplats.json
Show resolved
Hide resolved
...ing.dirigera/src/main/java/org/openhab/binding/dirigera/internal/DirigeraHandlerFactory.java
Show resolved
Hide resolved
...era/src/test/java/org/openhab/binding/dirigera/internal/handler/matter/TestMatterOutlet.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for Matter plugs GRILLPLATS and TOFSMYGGA.
Fixes #20436