Skip to content

Declare bus before its usage.#130

Merged
cfuguet merged 1 commit intoopenhwgroup:masterfrom
FondazioneChipsIT:yt/declare
Mar 19, 2026
Merged

Declare bus before its usage.#130
cfuguet merged 1 commit intoopenhwgroup:masterfrom
FondazioneChipsIT:yt/declare

Conversation

@yvantor
Copy link
Contributor

@yvantor yvantor commented Mar 16, 2026

The word_sel_rd bus is used (line 458) before its declaration (line 924).

@yvantor yvantor requested a review from cfuguet as a code owner March 16, 2026 07:02
@yvantor yvantor changed the title Declare bus before use. Declare bus before its usage. Mar 16, 2026
Copy link
Contributor

@cfuguet cfuguet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch ! Thank you @yvantor for the fix. Could you please sign the Eclipse Contributor Agreement so I can merge your PR ? This is a requirement if you want to contribute to OpenHW / Eclipse projects.

Thank you

@yvantor
Copy link
Contributor Author

yvantor commented Mar 19, 2026

@cfuguet done :)

@cfuguet cfuguet self-assigned this Mar 19, 2026
@cfuguet cfuguet added the bug Something isn't working label Mar 19, 2026
@cfuguet cfuguet merged commit 290e11b into openhwgroup:master Mar 19, 2026
20 checks passed
@cfuguet
Copy link
Contributor

cfuguet commented Mar 19, 2026

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants