8308105: Multi-array allocations are very slow#30550
Draft
bulasevich wants to merge 1 commit intoopenjdk:masterfrom
Draft
8308105: Multi-array allocations are very slow#30550bulasevich wants to merge 1 commit intoopenjdk:masterfrom
bulasevich wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back bulasevich! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@bulasevich The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
liach
reviewed
Apr 3, 2026
| address fun = nullptr; | ||
| switch (ndimensions) { | ||
| case 1: ShouldNotReachHere(); break; | ||
| case 2: fun = OptoRuntime::multianewarray2_Java(); break; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multidimensional array allocations such as new int[n1][n2] are very slow because HotSpot routes them through a runtime call (multianewarray) that allocates the outer array and each subarray sequentially.
For constant-size cases like new int[2][2], C2 already optimizes during the parse phase by inlining a fixed number of AllocateArray nodes. This change extends that optimization to the variable-size 2D case. When ndimensions == 2, Parse::do_multianewarray now calls Parse::init_array2d, which builds a C2 IR graph equivalent to:
The performance result is like this:
Status:
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30550/head:pull/30550$ git checkout pull/30550Update a local copy of the PR:
$ git checkout pull/30550$ git pull https://git.openjdk.org/jdk.git pull/30550/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 30550View PR using the GUI difftool:
$ git pr show -t 30550Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30550.diff