8372170: Implementation for Enhanced Local Variable Declarations (Preview)#30556
Draft
biboudis wants to merge 1 commit intoopenjdk:masterfrom
Draft
8372170: Implementation for Enhanced Local Variable Declarations (Preview)#30556biboudis wants to merge 1 commit intoopenjdk:masterfrom
biboudis wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back abimpoudis! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
openjdk
bot
added
core-libs
Member
Author
|
/jep JDK-8357464 |
|
@biboudis |
liach
reviewed
Apr 3, 2026
| JCExpression letBoundCandidateIdent = make.Ident(letBoundCandidate).setType(tempType); | ||
|
|
||
| // npe logic | ||
| JCIf ifNPEstatement = make.If(makeBinary(Tag.EQ, letBoundCandidateIdent, makeNull()).setType(syms.booleanType), |
Member
There was a problem hiding this comment.
Why not attr.makeNullCheck? Redundant NPE type for Symtab too.
| @@ -0,0 +1,129 @@ | |||
| /* | |||
| * @test /nodynamiccopyright/ | |||
Member
There was a problem hiding this comment.
Don't think we should do nodynamiccopyright if this doesn't have a golden file output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the proposed patch for Enhanced Local Variable Declarations (Preview).
Progress
Issues
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30556/head:pull/30556$ git checkout pull/30556Update a local copy of the PR:
$ git checkout pull/30556$ git pull https://git.openjdk.org/jdk.git pull/30556/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 30556View PR using the GUI difftool:
$ git pr show -t 30556Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30556.diff