Skip to content

8381639: Remove bug id 8381475 from test/jdk/tools/sincechecker/modules/jdk.compiler/JdkCompilerCheckSince.java#30570

Open
vicente-romero-oracle wants to merge 1 commit intoopenjdk:masterfrom
vicente-romero-oracle:JDK-8381639
Open

8381639: Remove bug id 8381475 from test/jdk/tools/sincechecker/modules/jdk.compiler/JdkCompilerCheckSince.java#30570
vicente-romero-oracle wants to merge 1 commit intoopenjdk:masterfrom
vicente-romero-oracle:JDK-8381639

Conversation

@vicente-romero-oracle
Copy link
Copy Markdown
Contributor

@vicente-romero-oracle vicente-romero-oracle commented Apr 3, 2026

Bug id 8381475 was added to test JdkCompilerCheckSince.java because it detected several missing @since javadoc tags in new methods added by [1]. But the test was not modified as part of the fix for [2]. So this PR is just removing the 8381475 bug id from the test,

TIA

[1] JDK-8380147
[2] JDK-8381475


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8381639: Remove bug id 8381475 from test/jdk/tools/sincechecker/modules/jdk.compiler/JdkCompilerCheckSince.java (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30570/head:pull/30570
$ git checkout pull/30570

Update a local copy of the PR:
$ git checkout pull/30570
$ git pull https://git.openjdk.org/jdk.git pull/30570/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30570

View PR using the GUI difftool:
$ git pr show -t 30570

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30570.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Apr 3, 2026

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 3, 2026

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8381639: Remove bug id 8381475 from test/jdk/tools/sincechecker/modules/jdk.compiler/JdkCompilerCheckSince.java

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 3, 2026

@vicente-romero-oracle To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • net
  • nio
  • security
  • serviceability
  • shenandoah

Copy link
Copy Markdown
Member

@liach liach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc compiler

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Apr 4, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 4, 2026

@liach
The compiler label was successfully added.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 4, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Apr 4, 2026

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compiler compiler-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants