8281238: TYPE_USE annotations not printed in correct position in toString output

[cushon]

This backport of JDK-8281238 fixes a bug in TypeMirror#toString output when printing type annotations.

TypeMirror#toString is specified to return a string that is "suitable for representing this type in source code". This fix causes type annotations on qualified names to be printed at the correct location, for example java.lang.@Annotation String instead of @Annotation java.lang.String.

There was a bug in the initial fix for JDK-8281238, follow-on fix JDK-8284220 is included in this backport.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8281238 needs maintainer approval
• JDK-8284220 needs maintainer approval

Issues

• JDK-8281238: TYPE_USE annotations not printed in correct position in toString output (Bug - P3)
• JDK-8284220: TypeMirror#toString omits enclosing class names after JDK-8281238 (Bug - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4242/head:pull/4242
$ git checkout pull/4242

Update a local copy of the PR:
$ git checkout pull/4242
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4242/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4242

View PR using the GUI difftool:
$ git pr show -t 4242

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4242.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cushon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[cushon]

/issue add JDK-8284220

[openjdk]

@cushon
Adding additional issue to issue list: 8284220: TypeMirror#toString omits enclosing class names after JDK-8281238.

[mlbridge]

Webrevs

• 01: Full - Incremental (b8c1ea7c)
• 00: Full (c4ac9731)

[bridgekeeper]

@cushon This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!