8343622: AesDkCrypto.stringToKey should not return null

[alexeybakhtin]

I'd like to backport it for parity with oracle-8u491 and fix the NPE issue.

Almost clean backport from JDK11 PR with the following changes:

• JDK8 does not have JDK-8014628 "Support AES Encryption with HMAC-SHA2 for Kerberos 5 defined in RFC 8009". AesSha2DkCrypto.java is skipped
• NullStringToKey.java test is updated to verify SHA1 algorithms only

sun/security/krb5 JTREG tests are passed

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8343622 needs maintainer approval

Issue

• JDK-8343622: AesDkCrypto.stringToKey should not return null (Bug - P4 - Requested)

Reviewers

• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/769/head:pull/769
$ git checkout pull/769

Update a local copy of the PR:
$ git checkout pull/769
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/769/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 769

View PR using the GUI difftool:
$ git pr show -t 769

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/769.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (eea1217f)

[alexeybakhtin]

CI fails for CAInterop.java test and two GC-related tests. All failures are unrelated to the current changes

[gnu-andrew]

Looks good to me. Good call to use a String array in the test case to replace the List.of absent in 8u (and a List seems overkill anyway in this context)

[openjdk]

⚠️ @alexeybakhtin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.