8381563: [lworld] SharedRuntime::allocate_inline_types hits "buffer not of expected class" assert

[rwestrel]

Before allocating a new buffer for an value argument, SharedRuntime::allocate_inline_types_impl() looks for the buffer argument for that value in the compiled frame at the call. The current logic for that always uses the compiled calling convention which is wrong when SharedRuntime::allocate_inline_types_impl() is called from a ro entry point.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8381563: [lworld] SharedRuntime::allocate_inline_types hits "buffer not of expected class" assert (Bug - P3)

Reviewers

• Tobias Hartmann (@TobiHartmann - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2294/head:pull/2294
$ git checkout pull/2294

Update a local copy of the PR:
$ git checkout pull/2294
$ git pull https://git.openjdk.org/valhalla.git pull/2294/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2294

View PR using the GUI difftool:
$ git pr show -t 2294

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2294.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back roland! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rwestrel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8381563: [lworld] SharedRuntime::allocate_inline_types hits "buffer not of expected class" assert

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the lworld branch:

• 0d6bcd4: 8381686: [lworld] compiler/valhalla/inlinetypes/TestVirtualThreads.java still times out
• 3508b5a: 8381776: [lworld] cherry-pick JDK-8381475
• 92c5e58: 8379695: [lworld] Update GCBasher to use value classes
• ... and 3 more: https://git.openjdk.org/valhalla/compare/de4e3f5e0d297cf13f00af16dd91a035f0755af0...lworld

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (ee5fa8f3)

[TobiHartmann]

This looks good to me. Thanks for quickly addressing this! I'll re-run testing and will report back once it all passed.

[TobiHartmann]

All tests passed.

[rwestrel]

@TobiHartmann thanks for the review

[rwestrel]

/integrate

[openjdk]

Going to push as commit f3fe993.
Since your change was applied there have been 6 commits pushed to the lworld branch:

• 0d6bcd4: 8381686: [lworld] compiler/valhalla/inlinetypes/TestVirtualThreads.java still times out
• 3508b5a: 8381776: [lworld] cherry-pick JDK-8381475
• 92c5e58: 8379695: [lworld] Update GCBasher to use value classes
• ... and 3 more: https://git.openjdk.org/valhalla/compare/de4e3f5e0d297cf13f00af16dd91a035f0755af0...lworld

Your commit was automatically rebased without conflicts.

[openjdk]

@rwestrel Pushed as commit f3fe993.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.