Skip to content

8337056: [lworld] Document APIs that require Identity objects as parameters#2297

Open
liach wants to merge 1 commit intoopenjdk:lworldfrom
liach:doc/cleaner-identity-exception
Open

8337056: [lworld] Document APIs that require Identity objects as parameters#2297
liach wants to merge 1 commit intoopenjdk:lworldfrom
liach:doc/cleaner-identity-exception

Conversation

@liach
Copy link
Copy Markdown
Member

@liach liach commented Apr 3, 2026

The original RFE proposes to document where IdentityException would now be thrown. In the JDK, only the Cleaner constructor is missing this specification. I also shifted the identity check to method entry; before it was done in the superclass constructors.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8337056: [lworld] Document APIs that require Identity objects as parameters (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2297/head:pull/2297
$ git checkout pull/2297

Update a local copy of the PR:
$ git checkout pull/2297
$ git pull https://git.openjdk.org/valhalla.git pull/2297/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2297

View PR using the GUI difftool:
$ git pr show -t 2297

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2297.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Apr 3, 2026

👋 Welcome back liach! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 3, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title 8337056 8337056: [lworld] Document APIs that require Identity objects as parameters Apr 3, 2026
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 3, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Apr 3, 2026

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant