Conversation
- detects the header row(s) - detects the coding system - detects the column containing clinical codes
When passed a CSV file it: - detects the coding system, column containing the clinical codes, and the header row(s) if included - finds all the "missing" descendant concepts, that is any code not in the CSV, but where an ancestor code is in the CSV
- displays the number of header rows (or "no header row" if none found) - displays the detected coding system, and a warning if the selected coding system differs - displays the column number containing the clinical codes - displays up to the top 5 rows, and a final "xxx more rows" row if applicable
Given we can now autodetect the header we don't need to ask the user if there is one
- If checked the behaviour is the same as it used to be (i.e. child codes not in the CSV are explicitly excluded) - if unchecked, it causes all the child codes to be "unresolved" and require review on the builder screen
It's useful to the user to see in advance which child codes are missing from their CSV to help them decide whether to exclude them all
If the uploaded CSV has issues, then we know clicking create will just stay on the page and display the same error, so if we're already displaying the problem with the CSV then disable the button.
Uploads a CSV with and without checking the "exclude child codes" box.
Contributor
Author
|
The following issues can likely be closed when this change is merged:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent RSI iteration was on how people upload CSVs and whether the default of excluding all missing descendants was contributing to low quality codelists. This PR is the final interface following a few rounds of user testing.
csv-descendants-previewendpointThe benefits are:
Selected screenshots
1. Removed the "does your file have a header" radio. Updated help message to explain what will happen:

2. Display preview of CSV along with what was detected:

3. Check if detected coding system clashes with selected coding system:

4. Existing errors with CSVs can now be shown immediately. Previously this warning would only appear after page submission:

5. If there are missing children, we explain the options, and show which codes are missing:

6. Excluding missing child codes has a visual indicator in the list of missing codes:
