Updating composite engine reference before translog recovery #20449
Conversation
Signed-off-by: Raghuvansh Raj <[email protected]>
raghuvanshraj
requested review from
a team,
Bukhtawar,
CEHENKLE,
Rishikesh1159,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Comment |
|
❌ Gradle check result for 078a326: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
| LocalCheckpointTracker::new, | ||
| TranslogEventListener.NOOP_TRANSLOG_EVENT_LISTENER | ||
| ); | ||
| oldCompositeEngine = currentCompositeEngineReference.getAndSet(newCompositeEngine); |
There was a problem hiding this comment.
Shall we also add it in try block so that even if some exception comes after setting the newCompositeEngine while translog Recovery and all, still we can close the old engine?
bharath-techie
merged commit 729877d
into
opensearch-project:feature/datafusion
…rch-project#20449) Signed-off-by: Raghuvansh Raj <[email protected]>
4 participants
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.