Skip to content

Conversation

@bharath-techie
Copy link
Contributor

Description

The arrow arrays get sliced resulting in buffers having mismatches when passed to the java layer via FFI. So this fix includes compaction of variable length arrow arrays before passing via FFI

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@bharath-techie bharath-techie requested a review from a team as a code owner January 22, 2026 11:45
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 22, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

…gth arrow arrays before passing via FFI

Signed-off-by: bharath-techie <[email protected]>
Copy link
Contributor

@Bukhtawar Bukhtawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a test we can add?

@github-actions
Copy link
Contributor

❌ Gradle check result for 53e2fa9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@bharath-techie bharath-techie changed the title fix for head + offset queries by compacting variable length arrow arrays fix for head + offset queries by upgrading arrow version Jan 28, 2026
@bharath-techie bharath-techie merged commit 4ac7da0 into opensearch-project:feature/datafusion Jan 28, 2026
7 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants