-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add hook to provide GrpcInterceptorProvider Settings #20493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hook to provide GrpcInterceptorProvider Settings #20493
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
📝 WalkthroughWalkthroughThis change introduces settings initialization support for gRPC interceptor providers by adding a default Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
❌ Gradle check result for 9e74427: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
...nsport-grpc/spi/src/main/java/org/opensearch/transport/grpc/spi/GrpcInterceptorProvider.java
Outdated
Show resolved
Hide resolved
…Settings. Signed-off-by: Finn Carroll <[email protected]>
5e99093 to
79cfd87
Compare
|
❌ Gradle check result for 79cfd87: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 79cfd87: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20493 +/- ##
============================================
- Coverage 73.25% 73.24% -0.01%
+ Complexity 71979 71966 -13
============================================
Files 5796 5797 +1
Lines 329287 329329 +42
Branches 47419 47430 +11
============================================
Hits 241203 241203
- Misses 68759 68792 +33
- Partials 19325 19334 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
At high level LGTM, @finnegancarroll can you fix the codecov ? |
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
|
Thanks for taking a look @prudhvigodithi , adding a small unit test to bolster code cov here. This line seems to functionally used all over the tests but with objects that are provided by Mockito which confuses code cov. |
Description
Plugins implementing a GrpcInterceptorProvider may want their interceptor behavior to depend on settings.
This change adds an
initSettingshook called onGrpcPlugin.createComponentswhich provides these interceptors visibility into settings.Related Issues
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.