Skip to content

Conversation

@chrisale000
Copy link
Contributor

Description

  • Add @Named and @Inject annotations for direct component scanning
  • Office365 uses enableSubscriptionMetrics() at earliest initialization stage
  • Maintain full backward compatibility with existing injection.
  • Remove Rest Client Logging as this logging is covered in the crawler and the request can be recreated.

Testing: Verified both patterns generate metrics successfully

  • Spun Up Multiple pipelines locally and confirmed:
    • Direct injection via @Named/@Inject (subscription metrics disabled by default) ✓
    • Office365: Early enablement in Source constructor ensures metrics available throughout lifecycle ✓
    • Comprehensive test coverage for enablement functionality and constructor behavior ✓
    • Backwards compatibility ✓

Issues Resolved

N/A

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants