Skip to content

CNFCERT-1258: Add kustomize validation check#3054

Open
sebrandon1 wants to merge 2 commits intoopenshift-kni:mainfrom
sebrandon1:add_kustomization_test
Open

CNFCERT-1258: Add kustomize validation check#3054
sebrandon1 wants to merge 2 commits intoopenshift-kni:mainfrom
sebrandon1:add_kustomization_test

Conversation

@sebrandon1
Copy link
Contributor

Similar to: openshift-kni/telco-reference#433

Changes:

  • Adds a quick PR check that attempts to kustomize build appropriate files. Only runs against main.
  • Adds a make path for make test-kustomize which runs the script. Users can run this locally as well as there are safeguards to ensure kustomize exists first.
  • Skips YAMLs that might require external plugins. See EXCLUDED_DIRS.

Example run:

$ make test-kustomize 
hack/test-kustomize.sh
Generating temporary patch file for validation: ./config/manager/related-images/patch.yaml

Checking all kustomization.yaml files can build successfully...

  ./config/crd: OK
  ./config/default: OK
  ./config/manager: OK
  ./config/manifests: OK
  ./config/networkpolicies: OK
  ./config/prometheus: OK
  ./config/rbac: OK
  ./config/samples: OK
  ./config/scorecard: OK

Summary: Checked 9 kustomization.yaml files, skipped 0 (require external plugins)
All kustomization files validated successfully!

Cleaning up temporary files...
  Removed: ./config/manager/related-images/patch.yaml
Kustomize validation completed successfully.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jc-rh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sebrandon1 sebrandon1 force-pushed the add_kustomization_test branch from bda0fd3 to 9e3d962 Compare October 30, 2025 20:05
@sebrandon1 sebrandon1 force-pushed the add_kustomization_test branch from 9e3d962 to cd26643 Compare November 21, 2025 20:21
@sebrandon1 sebrandon1 force-pushed the add_kustomization_test branch from cd26643 to f20c118 Compare December 16, 2025 19:44
@sebrandon1 sebrandon1 force-pushed the add_kustomization_test branch from f20c118 to d88abd7 Compare January 13, 2026 15:04
@sebrandon1 sebrandon1 changed the title Add kustomize validation check CNFCERT-1258: Add kustomize validation check Jan 16, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 16, 2026

@sebrandon1: This pull request references CNFCERT-1258 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Similar to: openshift-kni/telco-reference#433

Changes:

  • Adds a quick PR check that attempts to kustomize build appropriate files. Only runs against main.
  • Adds a make path for make test-kustomize which runs the script. Users can run this locally as well as there are safeguards to ensure kustomize exists first.
  • Skips YAMLs that might require external plugins. See EXCLUDED_DIRS.

Example run:

$ make test-kustomize 
hack/test-kustomize.sh
Generating temporary patch file for validation: ./config/manager/related-images/patch.yaml

Checking all kustomization.yaml files can build successfully...

 ./config/crd: OK
 ./config/default: OK
 ./config/manager: OK
 ./config/manifests: OK
 ./config/networkpolicies: OK
 ./config/prometheus: OK
 ./config/rbac: OK
 ./config/samples: OK
 ./config/scorecard: OK

Summary: Checked 9 kustomization.yaml files, skipped 0 (require external plugins)
All kustomization files validated successfully!

Cleaning up temporary files...
 Removed: ./config/manager/related-images/patch.yaml
Kustomize validation completed successfully.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sebrandon1
Copy link
Contributor Author

/retest

@sebrandon1 sebrandon1 force-pushed the add_kustomization_test branch from d88abd7 to 15b2e13 Compare February 25, 2026 20:49
@sebrandon1 sebrandon1 force-pushed the add_kustomization_test branch from 15b2e13 to 0bcb84b Compare February 25, 2026 21:21
@sebrandon1
Copy link
Contributor Author

/retest

Remove trailing whitespace on blank lines that causes bashate E001
failures in CI.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2026

@sebrandon1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration 231c2f8 link true /test integration

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants