no-jira: ibmcloud: fix region survey default value

[Pacho20]

In the ibmcloud selectRegion function, the Default parameter for survey.Select was incorrectly formatted. The longRegions slice already contains properly formatted strings (e.g., "us-south (Dallas)"), but the code attempted to format them again using fmt.Sprintf with a map lookup that would fail, resulting in malformed defaults like "us-south (Dallas) ()".

This bug was latent but became visible after upgrading the survey library from v2.3.5 to v2.3.7, which introduced strict validation requiring the Default value to exactly match one of the Options. This caused install-config creation to fail with an error.

This commit fixes the issue by using the first element of longRegions directly as the default value, without additional formatting.

[openshift-ci-robot]

@Pacho20: This pull request explicitly references no jira issue.

Details

In response to this:

In the ibmcloud selectRegion function, the Default parameter for survey.Select was incorrectly formatted. The longRegions slice already contains properly formatted strings (e.g., "us-south (Dallas)"), but the code attempted to format them again using fmt.Sprintf with a map lookup that would fail, resulting in malformed defaults like "us-south (Dallas) ()".

This bug was latent but became visible after upgrading the survey library from v2.3.5 to v2.3.7, which introduced strict validation requiring the Default value to exactly match one of the Options. This caused install-config creation to fail with an error.

This commit fixes the issue by using the first element of longRegions directly as the default value, without additional formatting.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hi @Pacho20. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[TwoDCube]

/ok-to-test

[rvanderp3]

/lgtm

[tthvo]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tthvo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/asset/installconfig/ibmcloud/OWNERS [tthvo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tthvo]

/cc @MayXuQQ

Could you help us verify this?

[openshift-ci]

@Pacho20: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-ibmcloud-ovn	440c7f7	link	false	/test e2e-ibmcloud-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.