Skip to content

fix: gold pouch and manage issues#3779

Draft
kasajames wants to merge 3 commits intoopentibiabr:mainfrom
kasajames:fix
Draft

fix: gold pouch and manage issues#3779
kasajames wants to merge 3 commits intoopentibiabr:mainfrom
kasajames:fix

Conversation

@kasajames
Copy link
Contributor

No description provided.

@sonarqubecloud
Copy link

@majestyotbr majestyotbr changed the title Fix: gold punch and manage issues Fix: gold pouch and manage issues Nov 28, 2025
@majestyotbr majestyotbr changed the title Fix: gold pouch and manage issues fix: gold pouch and manage issues Nov 28, 2025
@lamonato29
Copy link
Contributor

what it exactly fixes?

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale No activity label Jan 7, 2026
@dudantas
Copy link
Member

Thanks for the contribution, but this PR needs more context before it can be properly reviewed.

The pull request does not follow the project’s PR template and does not explain what problem is being solved, why these changes are necessary, or what behavior is expected after the fix. The description only states that it “fixes” something, which is not sufficient for maintainers or reviewers to evaluate the impact.

Specifically:

  • The removal of the gold pouch restriction in playerSetManagedContainer is not justified.
  • The fallback logic added in Player::getManagedContainer changes behavior, but the reasoning is unclear.
  • The condition change in internalCollectManagedItems alters loot handling logic without any explanation or reference to a reported issue.

Please update the PR description to include:

  • A clear explanation of the bug or limitation being addressed
  • Steps to reproduce the issue (if applicable)
  • The expected behavior before and after the change
  • Any related issue or discussion that motivated this PR

Once the PR is properly documented, it will be easier to review the changes and assess whether they should be merged.

@dudantas dudantas marked this pull request as draft January 12, 2026 14:21
@github-actions github-actions bot removed the Stale No activity label Jan 13, 2026
@github-actions
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale No activity label Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stale No activity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants