Skip to content

feat: protocol 15.21#3808

Draft
Zbizu wants to merge 21 commits intoopentibiabr:mainfrom
Zbizu:protocol1521
Draft

feat: protocol 15.21#3808
Zbizu wants to merge 21 commits intoopentibiabr:mainfrom
Zbizu:protocol1521

Conversation

@Zbizu
Copy link
Contributor

@Zbizu Zbizu commented Jan 19, 2026 •
edited
Loading

Description

  • implements compatibility with 15.21
  • contains protocol changes only
  • will not include new items, quests, map, or monsters (imo these should belong in separate pr)
  • built on top of monk branch, but compared to master, as a side effect the diff also contains some changes unrelated to this pr. Mind that this is a draft pr, it'll be remade.

new features since 15.00:

  • popup events
  • new npc chat window
  • (to do) task board
  • (to do) new stats in cyclopedia character pages

pr information:

  • forked from branch dudantas/feat-monk
  • currently waiting for version 15.00 to be merged
  • will likely need remaking or resolving conflicts, we'll see

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

  • selectively enabling and sending various packets to the client, fixing those that were breaking it
  • will need more testing

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

dudantas and others added 19 commits January 10, 2026 16:14
@dudantas @murilo09
@phacUFPE @FelipePaluco
feat: monk and 15.00
fe4aecd 
There are some monk behaviors that are not reflecting reality.

I also took the opportunity to align the wording with tibia official
terms for monk harmony manipulation: spend and build.

- The whole party is being healed
- Spender spells are not healing
- Spenders are not building, when using harmony virtue
- Harmony healing is constant, regardless of how many charges are being
built

- Spenders also heals
- Spenders should also build, when using harmony virtue
- Party healing impacts only the lower-health player, not the whole
party
- Harmony passive healing is proportional to the amount of harmony
built/spent

Co-Authored-By: murilo09 <78226931+murilo09@users.noreply.github.com>
Co-Authored-By: Pedro Cruz <phac@cin.ufpe.br>
Co-Authored-By: Felipe <87909998+FelipePaluco@users.noreply.github.com>
Co-Authored-By: Vava <110659678+vavasz@users.noreply.github.com>
@dudantas
Refactor Player::onThink for Spectators usage
8782921 
Replaced static Spectators::find call with instance method and updated callback execution to remove redundant argument. This improves code clarity and aligns with updated Spectators and callback APIs.
@dudantas
fix: sonar issues
9ba0c9d
@github-actions
Code format - (Clang-format)
e7a509d
@dudantas
Merge branch 'main' into dudantas/feat-monk
95b2367
@Zbizu
Merge branch 'main' into test1520
1584548
@Zbizu
feat: selective packet disabling
b45baaf
@Zbizu
cleanup passives and add checks to missed places
301fb86
@Zbizu
basic login, allow session keys with 4 fields, some code cleanup
6d2b550
@Zbizu
lua channel
c328ddc
@Zbizu
update sendStats
96b3d91
@Zbizu
add possibility to set effect source in sendMagicEffect
eef993e
@Zbizu
appearances 15.21.1b752f
aad737e
@Zbizu
distance effects
ce87915
@Zbizu
cyclopedia basic char info
ed5d9c6
@Zbizu
update fluid names to values confirmed on 17 jan 2026
7d7d798
@Zbizu
placeholders for cyclopedia pages
905d577
@Zbizu
updated npc system
ff9e95a
@Zbizu
update screenshot packet
248bec7
@coderabbitai
Copy link

coderabbitai bot commented Jan 19, 2026 •
edited
Loading

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kokekanon kokekanon mentioned this pull request Jan 19, 2026
Draft
16 tasks
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 29, 2026

Quality Gate Passed Quality Gate passed

Issues
96 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.1% Duplication on New Code

See analysis details on SonarQube Cloud

dudantas
dudantas reviewed Feb 23, 2026
View reviewed changes
src/server/network/protocol/protocolgame.cpp
@@ -4021,10 +4064,15 @@ void ProtocolGame::sendCyclopediaCharacterStoreSummary() {
msg.addByte(hItem_it.second);
}

// the packet should end with u16 but something was added in the middle
// this is a placeholder
msg.addByte(0);
Copy link
Member

@dudantas dudantas Feb 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The byte has from "prey unlocked" changed to u16: https://github.com/Zbizu/canary/blob/f7afa1cd3897319b305549d46e19ec9a33a1d821/src/server/network/protocol/protocolgame.cpp#L4026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dudantas dudantas dudantas left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Zbizu @dudantas