Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a dedicated “fx” button to each track header and wires it up so the header reflects Mix FX enablement changes after the Mix FX dialog is applied.
Changes:
- Added a new track-header toolbar button to open the Mix FX dialog and visually indicate whether Mix FX is enabled.
- Introduced a
MixFxChangedNotificationmessage and broadcast it when Mix FX changes are applied. - Updated track header view models/canvas to track and refresh
MixFxEnabledstate.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| OpenUtau/Views/MixFxDialog.axaml.cs | Sends a MessageBus notification after applying Mix FX so UI can refresh. |
| OpenUtau/ViewModels/TracksViewModel.cs | Adds MixFxChangedNotification message type. |
| OpenUtau/ViewModels/TrackHeaderViewModel.cs | Adds MixFxEnabled reactive state and syncs it with UTrack.MixFx.Enabled. |
| OpenUtau/Controls/TrackHeaderCanvas.cs | Listens for Mix FX change notifications and refreshes affected header VM. |
| OpenUtau/Controls/TrackHeader.axaml | Adds the “fx” button and styles for on/off visual state. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.