Skip to content

Fix the accuracy issue by update celu formula based on spec#33500

Open
sgbihu wants to merge 9 commits intoopenvinotoolkit:masterfrom
sgbihu:fix_celu
Open

Fix the accuracy issue by update celu formula based on spec#33500
sgbihu wants to merge 9 commits intoopenvinotoolkit:masterfrom
sgbihu:fix_celu

Conversation

@sgbihu
Copy link
Contributor

@sgbihu sgbihu commented Jan 8, 2026

Details:

  • The implementation didn't align with ONNX spec.
max(0,x) + min(0,alpha*(exp(x/alpha)-1))

Tickets:

@sgbihu sgbihu requested a review from a team as a code owner January 8, 2026 04:51
@sgbihu sgbihu requested review from Copilot and removed request for a team January 8, 2026 04:51
@github-actions github-actions bot added the category: ONNX FE OpenVINO ONNX FrontEnd label Jan 8, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the CELU (Continuously Differentiable Exponential Linear Unit) implementation to match the ONNX specification formula: max(0,x) + min(0,alpha*(exp(x/alpha)-1)). The previous implementation incorrectly used the ELU operator instead of explicitly implementing the CELU formula.

Key Changes:

  • Replaced ELU-based implementation with explicit formula computation using maximum, minimum, exponential, and arithmetic operations
  • Added necessary OpenVINO operation headers (Add, Exp, Maximum, Minimum, Subtract)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sgbihu sgbihu requested a review from Copilot January 8, 2026 04:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sgbihu sgbihu requested a review from mvafin January 8, 2026 04:54
Copy link
Collaborator

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add layer tests reproducing this issue

@rkazants rkazants added the pr: needs tests PR needs tests updating label Jan 8, 2026
@sgbihu sgbihu requested a review from rkazants January 8, 2026 06:35
Copy link
Contributor

@mvafin mvafin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see celu also exist in pytorch. Can you check if the same fix is needed for pytorch?

@sgbihu sgbihu requested a review from mvafin January 9, 2026 08:17
@sgbihu sgbihu requested a review from a team as a code owner January 9, 2026 08:17
@sgbihu
Copy link
Contributor Author

sgbihu commented Jan 9, 2026

I see celu also exist in pytorch. Can you check if the same fix is needed for pytorch?

Fixed.

@github-actions github-actions bot added the category: PyTorch FE OpenVINO PyTorch Frontend label Jan 9, 2026
@sgbihu sgbihu requested review from Copilot and mvafin January 12, 2026 23:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sgbihu sgbihu force-pushed the fix_celu branch 3 times, most recently from 27707be to 038993f Compare January 26, 2026 02:07
sgbihu and others added 2 commits March 16, 2026 15:44
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

1.175494350822288e-38f,
7.346839692639297e-40f,
0.0f,
inf,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: ONNX FE OpenVINO ONNX FrontEnd category: PyTorch FE OpenVINO PyTorch Frontend pr: needs tests PR needs tests updating

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants