Fix the accuracy issue by update celu formula based on spec#33500
Fix the accuracy issue by update celu formula based on spec#33500sgbihu wants to merge 9 commits intoopenvinotoolkit:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the CELU (Continuously Differentiable Exponential Linear Unit) implementation to match the ONNX specification formula: max(0,x) + min(0,alpha*(exp(x/alpha)-1)). The previous implementation incorrectly used the ELU operator instead of explicitly implementing the CELU formula.
Key Changes:
- Replaced ELU-based implementation with explicit formula computation using maximum, minimum, exponential, and arithmetic operations
- Added necessary OpenVINO operation headers (Add, Exp, Maximum, Minimum, Subtract)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rkazants
left a comment
There was a problem hiding this comment.
please add layer tests reproducing this issue
mvafin
left a comment
There was a problem hiding this comment.
I see celu also exist in pytorch. Can you check if the same fix is needed for pytorch?
Fixed. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
27707be to
038993f
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Details:
Tickets: