fix(notebook): resolve execution-order dependency for optimized_models_dict in SD3 Torch.FX notebook#3365
Open
Aadik1ng wants to merge 2 commits intoopenvinotoolkit:latestfrom
Open
Conversation
- Relocated initialization of 'optimized_models_dict' to ensure it's defined before first usage in calibration data collection. - Ensured 'optimized_models_dict' is correctly scoped within the quantization-only sections to avoid NameErrors. - Restored necessary 'numpy' imports and removed unused/redundant imports found by nbqa flake8. - Improved overall notebook robustness for non-linear execution.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an execution-order dependency issue in the Stable Diffusion v3 Torch.FX notebook where
optimized_models_dictwas used before being defined, causing a potentialNameErrorduring quantization workflows.Changes
optimized_models_dictinto the quantization section (Cell 19) under the conditional%%skip not $to_quantize.valueblocknumpyimport to ensure downstream cells execute correctlyImpact
Type of Change
Validation
Notes
This change preserves the original intent of conditional execution while ensuring the notebook behaves reliably in typical interactive usage scenarios.