fix(core): add customContexts to default context#2599
fix(core): add customContexts to default context#2599lotharking wants to merge 4 commits intoopenwallet-foundation:mainfrom
Conversation
Signed-off-by: andres vallecilla <andresfelipe083195@hotmail.com>
|
TimoGlastra
left a comment
There was a problem hiding this comment.
What if you provide a custom document loader? Then the customContexts does not really have effect right?
Should we make this a parameter to the default document loader, e.g.
documenLoader: defaultDocumentLoader(additionalContexts)
So it's more clear that this is an extension to the default document loader?
Or we should change the behavior maybe, that if a custom context is defined it will ALWAYS use that first, otherwise it will fallback to the document loader. That way the custom contexts are always used
…ogic Signed-off-by: andres vallecilla <andresfelipe083195@hotmail.com>
|
With this implementation, we can reuse the default document loader and create a customized by extending it with additional context. |
Previously, adding a custom document loader required implementing a completely new class. This often caused confusion and introduced unnecessary complexity, especially when only a single additional requirement was needed. By adding a complementary custom document loader, users can add new contexts for specific scenarios.