snort3: refactor architecture-specific dependencies and CMake options#27624
Merged
BKPepe merged 1 commit intoopenwrt:openwrt-24.10from Oct 8, 2025
Merged
snort3: refactor architecture-specific dependencies and CMake options#27624BKPepe merged 1 commit intoopenwrt:openwrt-24.10from
BKPepe merged 1 commit intoopenwrt:openwrt-24.10from
Conversation
1. Enabled hyperscan/vectorscan together with adding dependency only for x86_64 and aarch64. 2. Disabled tmalloc (from gperftools package) for powerpc and mips. By doing this refactor, snort3 is going to be available for more OpenWrt devices (as it was in the past) as currently it was compiled only for x86_x64 and aarch64 by mistake. Fixes: 257e2fc ("snort3: fix logic in gpertools-runtime depends") Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com> (cherry picked from commit 126364e) [For OpenWrt 24.10: There is hyperscan instead of vectorscan]
ed1e7e0 to
071fa03
Compare
Member
Author
|
Okay, all the CI/CD failures are related to testing inside the Docker container, it looks like: Not related, so this can be merged. |
Contributor
|
I have not tested with this branch but I have observed on main that the build system expects gperftools-runtime to be selected and fails when it is not. Is that the intended behavior considering how the build bots work and presumably have it already build as a module? Example: |
Member
Author
|
Okay, I think I know what is going on. Please create issue and I will address it for the master branch. I will merge this as it is, because it is cherry-pick. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintainer: @graysky2
By doing this refactor, snort3 is going to be available for more OpenWrt devices (as it was in the past) as currently it was compiled only for x86_x64 and aarch64 by mistake.
Fixes: 257e2fc ("snort3: fix logic in gpertools-runtime depends")
(cherry picked from commit 126364e)
[For OpenWrt 24.10: There is hyperscan instead of vectorscan]
Backport of #27037